From ff575c452bf68f8ecc739979b2638f2a06d1acce Mon Sep 17 00:00:00 2001 From: Keshav Bhatt Date: Wed, 31 Aug 2022 14:28:58 +0530 Subject: chore: some enhancements - webengine multiprocess - webengine disable sandbox - minor memory usage improvements --- src/webenginepage.cpp | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) (limited to 'src/webenginepage.cpp') diff --git a/src/webenginepage.cpp b/src/webenginepage.cpp index 9a35761..2694c20 100644 --- a/src/webenginepage.cpp +++ b/src/webenginepage.cpp @@ -8,8 +8,10 @@ WebEnginePage::WebEnginePage(QWebEngineProfile *profile, QObject *parent) : QWebEnginePage(profile, parent) { auto userAgent = profile->httpUserAgent(); - auto webengineversion = userAgent.split("QtWebEngine").last().split(" ").first(); - auto toRemove = "QtWebEngine"+webengineversion; + qDebug() << "WebEnginePage::Profile::UserAgent" << userAgent; + auto webengineversion = + userAgent.split("QtWebEngine").last().split(" ").first(); + auto toRemove = "QtWebEngine" + webengineversion; auto cleanUserAgent = userAgent.remove(toRemove).replace(" ", " "); profile->setHttpUserAgent(cleanUserAgent); @@ -149,15 +151,14 @@ QStringList WebEnginePage::chooseFiles(QWebEnginePage::FileSelectionMode mode, } QFileDialog *dialog = new QFileDialog(); + dialog->setAttribute(Qt::WA_DeleteOnClose, true); bool usenativeFileDialog = settings.value("useNativeFileDialog", false).toBool(); if (usenativeFileDialog == false) { dialog->setOption(QFileDialog::DontUseNativeDialog, true); } - dialog->setFileMode(dialogMode); - QStringList mimeFilters; mimeFilters.append("application/octet-stream"); // to show All files(*) mimeFilters.append(acceptedMimeTypes); @@ -182,6 +183,7 @@ bool WebEnginePage::certificateError(const QWebEngineCertificateError &error) { QWidget *mainWindow = view()->window(); if (error.isOverridable()) { QDialog dialog(mainWindow); + dialog.setAttribute(Qt::WA_DeleteOnClose, true); dialog.setModal(true); dialog.setWindowFlags(dialog.windowFlags() & ~Qt::WindowContextHelpButtonHint); -- cgit v1.2.3