From 5f10a0f9657358fcd86c55ec065f3855bad0c160 Mon Sep 17 00:00:00 2001 From: Keshav Bhatt Date: Wed, 17 May 2023 21:59:43 +0530 Subject: feat: minor fixes + code cleanup --- src/webview.cpp | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) (limited to 'src/webview.cpp') diff --git a/src/webview.cpp b/src/webview.cpp index 8029ffd..035fb4b 100644 --- a/src/webview.cpp +++ b/src/webview.cpp @@ -7,8 +7,7 @@ #include WebView::WebView(QWidget *parent, QStringList dictionaries) - : QWebEngineView(parent) { - dictionaries = dictionaries; + : QWebEngineView(parent), m_dictionaries(dictionaries) { QObject *parentMainWindow = this->parent(); while (!parentMainWindow->objectName().contains("MainWindow")) { @@ -99,22 +98,24 @@ void WebView::contextMenuEvent(QContextMenuEvent *event) { spellcheckAction->setCheckable(true); spellcheckAction->setChecked(pageWebengineProfile->isSpellCheckEnabled()); connect(spellcheckAction, &QAction::toggled, this, - [pageWebengineProfile, this](bool toogled) { + [pageWebengineProfile](bool toogled) { pageWebengineProfile->setSpellCheckEnabled(toogled); - settings.setValue("sc_enabled", toogled); + SettingsManager::instance().settings().setValue("sc_enabled", + toogled); }); menu->addAction(spellcheckAction); if (pageWebengineProfile->isSpellCheckEnabled()) { auto subMenu = menu->addMenu(tr("Select Language")); - for (const QString &dict : qAsConst(dictionaries)) { + for (const QString &dict : qAsConst(m_dictionaries)) { auto action = subMenu->addAction(dict); action->setCheckable(true); action->setChecked(languages.contains(dict)); - connect(action, &QAction::triggered, this, [pageWebengineProfile, dict, this]() { - pageWebengineProfile->setSpellCheckLanguages(QStringList() << dict); - settings.setValue("sc_dict", dict); - }); + connect( + action, &QAction::triggered, this, [pageWebengineProfile, dict]() { + pageWebengineProfile->setSpellCheckLanguages(QStringList() << dict); + SettingsManager::instance().settings().setValue("sc_dict", dict); + }); } } connect(menu, &QMenu::aboutToHide, menu, &QObject::deleteLater); -- cgit v1.2.3