From 54cee0326ce5a7fd9b117ca10e6a7e2dfe1a201b Mon Sep 17 00:00:00 2001
From: keshavbhatt <keshavnrj@gmail.com>
Date: Wed, 5 May 2021 19:22:49 +0530
Subject: fix file dialog.

---
 src/downloadmanagerwidget.cpp | 5 +++--
 src/mainwindow.cpp            | 7 ++++---
 src/webenginepage.cpp         | 9 +++++----
 3 files changed, 12 insertions(+), 9 deletions(-)

(limited to 'src')

diff --git a/src/downloadmanagerwidget.cpp b/src/downloadmanagerwidget.cpp
index 8ebc7e9..38271e8 100644
--- a/src/downloadmanagerwidget.cpp
+++ b/src/downloadmanagerwidget.cpp
@@ -16,8 +16,9 @@ void DownloadManagerWidget::downloadRequested(QWebEngineDownloadItem *download)
 {
     //Q_ASSERT(download && download->state() == QWebEngineDownloadItem::DownloadRequested);
     QString path;
-    if(settings.value("useNativeFileDialog",false).toBool() == false)
-    {
+
+    bool usenativeFileDialog = settings.value("useNativeFileDialog",false).toBool();
+    if(usenativeFileDialog == false){
         path = QFileDialog::getSaveFileName(this, tr("Save as"), download->path(),tr("Any file (*)"),nullptr,QFileDialog::DontUseNativeDialog);
     }else{
         path = QFileDialog::getSaveFileName(this, tr("Save as"), download->path(),tr("Any file (*)"),nullptr);
diff --git a/src/mainwindow.cpp b/src/mainwindow.cpp
index bd38f39..cdeab28 100644
--- a/src/mainwindow.cpp
+++ b/src/mainwindow.cpp
@@ -758,11 +758,12 @@ void MainWindow::loadingQuirk(QString test)
 void MainWindow::handleDownloadRequested(QWebEngineDownloadItem *download)
 {
     QFileDialog dialog(this);
-    if(settings.value("useNativeFileDialog",false).toBool() == false){
+    bool usenativeFileDialog = settings.value("useNativeFileDialog",false).toBool();
+
+    if(usenativeFileDialog == false){
         dialog.setOption(QFileDialog::DontUseNativeDialog,true);
-    }else{
-        dialog.setOption(QFileDialog::DontUseNativeDialog,false);
     }
+
     dialog.setAcceptMode(QFileDialog::AcceptMode::AcceptSave);
     dialog.setFileMode(QFileDialog::FileMode::AnyFile);
     QString suggestedFileName = QUrl(download->path()).fileName();
diff --git a/src/webenginepage.cpp b/src/webenginepage.cpp
index d92c3fc..f0155bc 100644
--- a/src/webenginepage.cpp
+++ b/src/webenginepage.cpp
@@ -138,13 +138,14 @@ QStringList WebEnginePage::chooseFiles(QWebEnginePage::FileSelectionMode mode, c
         }
 
         QFileDialog* dialog = new QFileDialog();
-        dialog->setFileMode(dialogMode);
-        if(settings.value("useNativeFileDialog",false).toBool() == false){
+        bool usenativeFileDialog = settings.value("useNativeFileDialog",false).toBool();
+
+        if(usenativeFileDialog == false){
             dialog->setOption(QFileDialog::DontUseNativeDialog,true);
-        }else{
-            dialog->setOption(QFileDialog::DontUseNativeDialog,false);
         }
 
+        dialog->setFileMode(dialogMode);
+
         QStringList mimeFilters;
         mimeFilters.append("application/octet-stream"); // to show All files(*)
         mimeFilters.append(acceptedMimeTypes);
-- 
cgit v1.2.3